Conversation
Vtec234
commented
May 7, 2026
| pid $NGINX_PID_PATH; | ||
| error_log $NGINX_ERROR_LOG_PATH; | ||
| # Run worker processes as root so that they can access root-owned Unix domain sockets. | ||
| user root; |
Member
Author
There was a problem hiding this comment.
This is a bit scary. On the other hand restricting nginx workers only feels a bit security-theater to me: if we do that, we should make all processes (next.js, the nginx root process, the bwraps) run as unprivileged users as well.
jcreedcmu
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it impossible for openvscode-server instances to make requests against other instances (see #16).
They are still able to make requests for Next.js: this is blocked by vercel/next.js#26424 (which has been open for seven years, so unlikely to get resolved). This is somewhat lower risk since Next.js does enforce authentication on all routes. However, it does mean we should not be trusting headers that Nginx sets (because we don't know the request really is coming from Nginx).
Depends on #17.